Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing generic examples on group page #4455

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fixing generic examples on group page #4455

merged 2 commits into from
Nov 13, 2023

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Nov 13, 2023 •
edited
Loading

What are you changing in this pull request and why?

Updating examples on the group reference page to include generic placeholder

Closes: #4418

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner November 13, 2023 18:46
@vercel Vercel
Copy link

vercel bot commented Nov 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 7:02pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs labels Nov 13, 2023
nghi-ly
nghi-ly approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a blocker, approving.

non-blocking comment: this doesn't quite comply with our style guide and i also see your question in the team slack channel.

@matthewshaver matthewshaver merged commit 7b4122f into current Nov 13, 2023
7 checks passed
@matthewshaver matthewshaver deleted the finance-fix branch November 13, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use <group_name> for generic syntax examples
2 participants
@matthewshaver @nghi-ly